-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move test dependencies to package metadata. #1981
Conversation
Unfortunately, this change causes the package to fail to install into tox on Python 2.7.
|
It seems that although the tests are running on Python 2.7, pip is installing pytest 5.3 and more-itertools 8, both of which are Python 3-only. But why? |
Oh, I know why. Now that deps and |
…es in metadata to be installed without ignoring REQUIRES_PYTHON
7a31a9d
to
d92f778
Compare
Although this latest implementation now runs successfully on Python 2.7, it still has issues even on Python 3, when setuptools isn't present when installing some dependencies that are only available as source. I was able to replicate the issue locally by running:
Error is:
|
…uptools to install test dependencies.
…sts with that setting.
e3a7874
to
620bd62
Compare
4f74375
to
b2845ed
Compare
…s jaraco/skeleton to build docs in tox and rtd.
5871f6d
to
641e088
Compare
This comment has been minimized.
This comment has been minimized.
I believe this change is basically ready to go. I'm a little sad the implementation adds so many lines of code, but it does have some benefits:
Does this change merit a changelog entry? Probably. |
Summary of changes
By declaring the dependencies in metadata, they become inspectable by other tools at runtime and are declared in the canonical location (currently setup.cfg) rather than in a bespoke location.
Furthermore, by removing the
./tests
directory, it avoids masking the issue reported in #1896.Pull Request Checklist