Skip to content

Commit

Permalink
Add news fragment.
Browse files Browse the repository at this point in the history
  • Loading branch information
jaraco committed Apr 13, 2024
1 parent 608de82 commit f07b037
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions newsfragments/+27489545.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Merged bugfix for pypa/distutils#246

5 comments on commit f07b037

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jaraco this issue number seems weird. What's it supposed to be? It references a non-existing page @ https://setuptools.pypa.io/en/stable/history.html#v69-4-2.

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a commit either: 27489545 / pypa/distutils@27489545...

@webknjaz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! So it seems like the change notes should be handled differently since Towncrier is likely dropping the + and then, some Sphinx extension auto-refences things with a hash and numbers following it.

@jaraco
Copy link
Member Author

@jaraco jaraco commented on f07b037 Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears to be another instance of twisted/towncrier#584. I'll repair the changelog by hand (assuming there's not already a PR doing so).

@jaraco
Copy link
Member Author

@jaraco jaraco commented on f07b037 Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in 6067fa4. Thanks for the heads up.

Please sign in to comment.