Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: fallback to toml if tomli is not available #125

Closed
wants to merge 1 commit into from

Conversation

FFY00
Copy link
Member

@FFY00 FFY00 commented Aug 2, 2021

We already have the code, as we support Python < 3.6, and being able to
fallback to toml if tomli is not available will make bootstraping Python
environments much easier.

Signed-off-by: Filipe Laíns lains@riseup.net

We already have the code, as we support Python < 3.6, and being able to
fallback to toml if tomli is not available will make bootstraping Python
environments much easier.

Signed-off-by: Filipe Laíns <lains@riseup.net>
@takluyver
Copy link
Member

I've actually been working on documenting how to bootstrap things without relying on setuptools: pypa/flit#441

As things stand, I'd be OK with doing the fallback like this. But I don't want to imply that the recommended way to bootstrap these packages is using setuptools. At some point - possibly quite soon - we'll drop support for Python 3.6, which is already out of security updates from the core developers. When we do, I'd like to go back to just importing one TOML parser (tomli). So bootstrappers should be prepared to do things that way.

@FFY00
Copy link
Member Author

FFY00 commented Sep 5, 2021

Once we get the wheel installer ready, I plan to write a bootstraping script that can build from source, and install, the packages necessary to bootstrap a Python environment, which should fix that issue.

Regardless of the future handling of the TOML parser dependency on this project, simply having a release that works with both toml and tomli would still be very helpful. So, if you could merge this and tag a release, it would be great. After that, feel free to hard depend on tomli.

@takluyver
Copy link
Member

Closing following discussion on #131 - @FFY00 said this turns out not to be so useful after all.

@takluyver takluyver closed this Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants