Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipenv 3000 install (behavioral refactor) #6098

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

matteius
Copy link
Member

@matteius matteius commented Feb 22, 2024

The issue

It has been long requested that:
pipenv install have the same behavior as pipenv sync when no packages are requested
and pipenv install package has the behavior of pipenv update
which means only pipenv lock will regenerate the whole lock.

Fixes #5992
Fixes #6070
Fixes #6048

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius changed the title Pipenv install refactor (draft) pipenv install (behavioral refactor) Apr 2, 2024
@matteius matteius changed the title pipenv install (behavioral refactor) pipenv 3000 install (behavioral refactor) Apr 2, 2024
@matteius matteius marked this pull request as ready for review April 2, 2024 23:35
@matteius matteius requested a review from oz123 April 2, 2024 23:49
@oz123
Copy link
Contributor

oz123 commented Apr 3, 2024

This PR looks good. What's still missing is an update to docs.

Copy link
Contributor

@oz123 oz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should definitely add documentation about this.

@Kroppeb
Copy link

Kroppeb commented Apr 5, 2024

Huh, I'm a bit confused. I only see the logic for pipenv install package having been changed. I don't see where you changed the behavior of pipenv install.

I know some people at my work sometimes edit the pipfile directly and then run pipenv install. Maybe it would be beneficial to see if the lockfile is up to date and if not use the old logic of lock & sync?

@matteius
Copy link
Member Author

matteius commented Apr 9, 2024

Huh, I'm a bit confused. I only see the logic for pipenv install package having been changed.

Thanks for checking, I probably missed something in the refactor -- will revisit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants