Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated BadZipfile with BadZipFile #5629

Merged
merged 1 commit into from Mar 12, 2023

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Mar 12, 2023

Thank you for contributing to Pipenv!

The issue

BadZipfile (with a small f) has been deprecated since Python 3.2.

The fix

Use BadZipFile (big F) instead, added in 3.2.

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

@matteius matteius merged commit b3abbf7 into pypa:main Mar 12, 2023
@hugovk hugovk deleted the replace-deprecated-BadZipfile branch March 13, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants