Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 21.1 #9828

Merged
merged 6 commits into from Apr 24, 2021
Merged

Release 21.1 #9828

merged 6 commits into from Apr 24, 2021

Conversation

sbidoul
Copy link
Member

@sbidoul sbidoul commented Apr 24, 2021

refs #9761

@sbidoul sbidoul added the skip news Does not need a NEWS file entry (eg: trivial changes) label Apr 24, 2021
@@ -9,6 +9,82 @@

.. towncrier release notes start

21.1 (2021-04-24)21.1 (2021-04-24)
=================
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbidoul I'm looking into how to fix this w/ towncrier. Seems like this is related to the NEWS handling changes done recently.

https://meet.google.com/fuw-tjbw-xyc is where I'll be sitting if you wanna join. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I'm going to fix that manually.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good! You'll need to amend the git tag too, if you're doing that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradyunsg I wanted to say hi, but you meet link above is incomplete.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meet.google.com/fuw-tjbw-xyc is where I'll be sitting if you wanna join. :)

I've left.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pradyunsg looks like this broken related to that towncrier compat "fix" #9817.

I've found out that towncrier produces a broken title while towncrier --draft (that my sphinx extension uses) produces a good one.

This problem has manifested itself in setuptools too: pypa/setuptools#2666. I'll probably be investigating this soonish and track the progress there.

@sbidoul
Copy link
Member Author

sbidoul commented Apr 24, 2021

Gah, we have a deprecation that breaks a test :/

@sbidoul
Copy link
Member Author

sbidoul commented Apr 24, 2021

I'm going to postpone that deprecation to 21.2 as
1/ I don't have time for a deep dive in that topic right now
2/ the last comments in #8711 seems to say that the alternative (--force-reinstall) is not satisfactory

@pradyunsg
Copy link
Member

One nit-pick: flipping the order of the test fixes vs "bump for release" commit.

@sbidoul
Copy link
Member Author

sbidoul commented Apr 24, 2021

Ok, and I squashed the NEWS.rst fix in to the "bump for release" commit

@sbidoul
Copy link
Member Author

sbidoul commented Apr 24, 2021

Tag 21.1 pushed and green.

Now I need permission to push to PyPI. @pradyunsg can you do that (my PyPI user is acsbidoul)

@pradyunsg
Copy link
Member

Heyo! I'd stepped away for lunch. Invite sent! :)

@sbidoul
Copy link
Member Author

sbidoul commented Apr 24, 2021

Heyo! I'd stepped away for lunch.

Same here :)

Invite sent! :)

And upload done! Thanks for helping out.

@sbidoul sbidoul merged commit a63fd65 into pypa:main Apr 24, 2021
@sbidoul sbidoul deleted the release-21.1 branch April 24, 2021 12:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants