Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't split git references on unicode separators #9827

Merged
merged 2 commits into from Apr 24, 2021
Merged

Don't split git references on unicode separators #9827

merged 2 commits into from Apr 24, 2021

Commits on Apr 24, 2021

  1. Don't split git references on unicode separators 

    Previously, maliciously formatted tags could be used to hijack a
commit-based pin. Using the fact that the split here allowed for
all of unicode's whitespace characters as separators -- which git allows
as a part of a tag name -- it is possible to force a different revision
to be installed; if an attacker gains access to the repository.

This change stops splitting the string on unicode characters, by forcing
the splits to happen on newlines and ASCII spaces.
    @pradyunsg
    pradyunsg committed Apr 24, 2021
    Copy the full SHA
    ca832b2 View commit details
    Browse the repository at this point in the history

  2. 📰

    @pradyunsg
    pradyunsg committed Apr 24, 2021
    Copy the full SHA
    0e4938d View commit details
    Browse the repository at this point in the history