Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change VCS tooling verbosity along with pip's verbosity #9639

Merged
merged 11 commits into from
Jan 25, 2022
Merged

Change VCS tooling verbosity along with pip's verbosity #9639

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
74e1822
Show git verbose output/progress at verbosity > 2
SnoopJ Feb 20, 2021
f312997
Merge upstream changes
SnoopJ Oct 6, 2021
3042def
Add verbose flag to fetch_new() for bazaar, mercurial, SVN
SnoopJ Oct 10, 2021
da5a3da
Pass verbosity level to VCS as an int
SnoopJ Oct 13, 2021
73990db
Update tests to use new verbosity parameter
SnoopJ Oct 19, 2021
4c2bfa9
Annotate flags tuple as variable-length
SnoopJ Oct 19, 2021
59b52e2
Run black
SnoopJ Oct 19, 2021
31e6b17
Add NEWS fragment
SnoopJ Oct 19, 2021
4586cdb
Describe user-facing behavior in news entry
uranusjr Oct 19, 2021
a76b02b
Merge main
SnoopJ Jan 16, 2022
87dbb0c
Merge branch 'main' into track-pip-verbosity-in-VCS
pradyunsg Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/pip/_internal/vcs/bazaar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,15 +33,16 @@ class Bazaar(VersionControl):
def get_base_rev_args(rev: str) -> List[str]:
return ["-r", rev]

def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
rev_display = rev_options.to_display()
logger.info(
"Checking out %s%s to %s",
url,
rev_display,
display_path(dest),
)
cmd_args = make_command("branch", "-q", rev_options.to_args(), url, dest)
flags = ('--verbose',) if verbose else ('--quiet',)
uranusjr marked this conversation as resolved.
Show resolved Hide resolved
cmd_args = make_command("branch", *flags, rev_options.to_args(), url, dest)
self.run_command(cmd_args)

def switch(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
Expand Down
7 changes: 4 additions & 3 deletions src/pip/_internal/vcs/mercurial.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,18 @@ class Mercurial(VersionControl):
def get_base_rev_args(rev: str) -> List[str]:
return [rev]

def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
rev_display = rev_options.to_display()
logger.info(
"Cloning hg %s%s to %s",
url,
rev_display,
display_path(dest),
)
self.run_command(make_command("clone", "--noupdate", "-q", url, dest))
flags = ('--verbose', ) if verbose else ('--quiet',)
self.run_command(make_command("clone", "--noupdate", *flags, url, dest))
self.run_command(
make_command("update", "-q", rev_options.to_args()),
make_command("update", *flags, rev_options.to_args()),
cwd=dest,
)

Expand Down
5 changes: 3 additions & 2 deletions src/pip/_internal/vcs/subversion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,17 +277,18 @@ def get_remote_call_options(self) -> CommandArgs:

return []

def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions) -> None:
def fetch_new(self, dest: str, url: HiddenText, rev_options: RevOptions, verbose: bool) -> None:
rev_display = rev_options.to_display()
logger.info(
"Checking out %s%s to %s",
url,
rev_display,
display_path(dest),
)
flags = () if verbose else ('--quiet')
cmd_args = make_command(
"checkout",
"-q",
*flags,
self.get_remote_call_options(),
rev_options.to_args(),
url,
Expand Down