Linter updates

[pradyunsg]

Carries forward #8803

Toward #8543

[pfmoore]

Drive-by comment - I really dislike the multiple changes to produce

from typing import (
    # ... many lines of names, one per line
)

rather than condensing them onto a single line. If there's any way to avoid that, I'd be really happy.

Hmm, maybe we add a file pip._internal.common_types and do from pip._internal.common_types import *. I bet black hates import * as well 🙁

[pradyunsg]

rather than condensing them onto a single line. If there's any way to avoid that, I'd be really happy.

Upcoming changes will do that (isort's black configuration does what you want here).

[pradyunsg]

Re-reading your comment, I'm actually a bit confused -- could you point to a specific line?

[pfmoore]

Sorry, it was very drive-by. Here's an example: https://github.com/pypa/pip/pull/8902/files#diff-4d153bf2a557be9dae85e703bace82d8L33

I don't care a lot in practice (and I was pleasantly surprised that this was the only style choice I didn't like). I was mostly just flagging it on the basis that it might be a config that can be changed.

Looking at https://black.readthedocs.io/en/stable/compatible_configs.html#why-those-options-above it's discussing

from third_party import (lib1, lib2, lib3,
                         lib4, lib5, ...)

being invalid, and the recommended alternative is

from third_party import (
    lib1,
    lib2,
    lib3,
    lib4,
)

My (strongly) preferred alternative is

from third_party import (
    lib1, lib2, lib3,
    lib4,
)

(with the libX lines being wrapped when they exceed the normal line length limit, not one-per-line). That's pip's current style, and I prefer it over either of the two versions in the black documentation.

Looking at https://github.com/PyCQA/isort#multi-line-output-modes, I'm referring to isort mode 5 ("Hanging Grid Grouped").

[pradyunsg]

That's a nightmare for merge conflicts though. :(

That formatting would allow for 2 PRs like:

from third_party import (
    awesome, lib1, lib2,
    lib3, lib4,
)

from third_party import (
    lib1, lib2, lib3,
    lib4, zebras
)

And I'm sure you can see why git won't like that. I think I'd initially added isort with mode 5, and we switched to mode 3 because of this issue.

[pradyunsg]

FWIW, this PR isn't adding any new style choices -- the update to isort 5 means that we're now sorting all groups of imports, including those inside the if MYPY_CHECKING and what not, which was not doing in isort 4.

All the black-related style and mode changes can be found in #8903.

[pradyunsg]

I think I'd initially added isort with mode 5, and we switched to mode 3 because of this issue.

#6755 -- yup. :)

[pfmoore]

That explains why it's a relatively small change. I'm not convinced by the git argument, it's more important to me that source code should be readable by humans than that computers have an easy time. And paging past a huge block of typing declarations at the top of the file damages readability, IMO.

But as I said on #8903, I don't have the energy to be a lone voice against the rising tide of auto-formatting enthusiasm. So 🤷 - I'll express my opinions in the future by swearing at black in commit messages 🙂

[pfmoore]

#6755 -- yup. :)

... and #6755 (comment) 🙂

[pradyunsg]

It's almost as if our opinions were the same the last time we discussed this. ;)

[webknjaz]

ouch... shouldn't EOL escaping be banned?

[pradyunsg]

It should, but that's isort doing this. :/

The black profile fixes this. 🤷🏻‍♂️

[pradyunsg]

I'mma merge this, coz... uhm... it's "only" version updates to our existing linters. We can discuss changing configuration separately, since that's unrelated to actually updating them (mostly!).