Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to Pathlib in tests #6326

Closed
wants to merge 1 commit into from
Closed

Switch to Pathlib in tests #6326

wants to merge 1 commit into from

Conversation

pradyunsg
Copy link
Member

This isn't completed yet.

I figured it's best to work in the open than in isolation.

@pradyunsg pradyunsg added the C: tests Testing and related things label Mar 11, 2019
@pradyunsg
Copy link
Member Author

I won't have time to complete this anytime soon but I wanted to at least put this in a discoverable spot.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added needs rebase or merge PR has conflicts with current master and removed needs rebase or merge PR has conflicts with current master labels Apr 10, 2019
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label May 5, 2019
@chrahunt
Copy link
Member

Related to #6050.

RonnyPfannschmidt
RonnyPfannschmidt reviewed Jun 30, 2019
View reviewed changes
tests/conftest.py
# Copy over our source tree so that each use is self contained
shutil.copytree(
SRC_DIR,
pip_src.abspath,
pip_src.absolute(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a str() wraparound

@chrahunt
Copy link
Member

OK to close this in favor of continuing work on #6050 in individual PRs?

@pradyunsg pradyunsg closed this Aug 17, 2019
@pradyunsg
Copy link
Member Author

YES!

@pradyunsg pradyunsg deleted the tests/adopt-pathlib branch August 27, 2019 08:14
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Sep 26, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt left review comments

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things needs rebase or merge PR has conflicts with current master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pradyunsg @BrownTruck @chrahunt @RonnyPfannschmidt