Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade packaging to 24.0 #12598

Closed
wants to merge 1 commit into from
Closed

Upgrade packaging to 24.0 #12598

wants to merge 1 commit into from

Conversation

zangruochen
Copy link

Upgrade packaging to 24.0.

Removed LegacyVersion and LegacySpecifiler related code as packaging has removed LegacyVersion and LegacySpecifiler.

pypa/packaging#407

@notatallshaw
Copy link
Contributor

notatallshaw commented Mar 26, 2024

Are you familiar with the existing PR that has been attempting to do this #12300?

Also note any PR that does this must at every step of collecting packages skip versions and specifiers that now fail to parse, otherwise during backtracking, metadata and link collection pip will error out incorrectly, (some good example installs to try would be pytz, nltk, apache-airflow[all], and pandas, and these need to tries on pypi, and downlodaing all the packages and using --find-links against a url and a file system).

And finally, and I'm sure pip maintainers are well aware of this, but while pip desperately needs to upgrade packaging for a whole host of reasons it will be a disruptive breaking changing, uv has had to support many non-standard version and specifiers to be compatible with the Python packaging ecosystem, even though pip has been warning now for many releases that legacy versions and specifiers will fail in an upcoming release. Not sure what can be done about that, but it's been eye opening watching uv have to add support for lots of non-standard versions and specifiers.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants