Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate uninstallation errors to diagnostic error format #12463

Merged
merged 1 commit into from
May 4, 2024
Merged

Migrate uninstallation errors to diagnostic error format #12463

merged 1 commit into from
May 4, 2024

Conversation

ichard26
Copy link
Member

@ichard26 ichard26 commented Jan 5, 2024 •
edited

Towards #10421.

image

@ichard26
Copy link
Member Author

ichard26 commented Jan 5, 2024

lol, I forgot about the changelog. I'll provide changelogs per PR I file, although once this effort is over, I may reorganise them in a follow-up PR.

@ichard26 ichard26 marked this pull request as draft March 11, 2024 03:59
@pradyunsg
Copy link
Member

@ichard26 Why is this PR marked as a draft?

@ichard26 ichard26 marked this pull request as ready for review April 27, 2024 22:08
@ichard26
Copy link
Member Author

ichard26 commented Apr 27, 2024 •
edited

Whelp, macOS CI is currently borked. I suppose as long as the Windows jobs work, this PR should be fine.

Anyway, I updated the PR with minor changes to the formatting:

  • Wrapped the messages in Text(...) to avoid highlighting
  • Removed the surrounding punctuation for the "you may be able to recover" command suggestion as it makes copying n' pasting more difficult than it should be

The screenshot in the PR description has been updated.

@ichard26 ichard26 changed the title Migrate uninstallation errors to rich error format Migrate uninstallation errors to diagnostic error format Apr 27, 2024
@ichard26
Copy link
Member Author

#12645 is also relevant here. The current suggestion to use --force-reinstall just errors out with the same no record file found error. Should we suggest --ignore-installed instead?

@pradyunsg pradyunsg merged commit d2f2da9 into pypa:main May 4, 2024
24 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@uranusjr uranusjr uranusjr approved these changes

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ichard26 @pradyunsg @uranusjr