Merge link_hash back into _hashes #11696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
added
the
skip news
uranusjr
force-pushed
the
fix-link-hashes
branch
from
75c8b12
to
926ae96
Compare
Commit bad03ef introduced the new link_hash attribute that holds the link's hash info, but that attribute does the same thing as _hashes, and some existing usages still populate that old attribute. Since the plural variant covers more use cases (a file can be hashed with multiple algorithms), we restore the old logic that uses _hashes before the commit, and consolidate link_hash back into that attribute.
uranusjr
force-pushed
the
fix-link-hashes
branch
from
926ae96
to
0233bf2
Compare
pradyunsg
approved these changes
Jan 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I’m not sure how to describe this, but my instinct is trying to tell me something’s wrong.
I was investigating #11692 and suddenly realised that
Linkcurrently has a totally unused attribute_hashes. This was introduced quite a while ago, and was (as the name suggests) used to check whether the linked file is valid. But in bad03ef, a new attributelink_hashwas introduced to do the same thing (? not entirely sure) but more limited (only one hash value) and removed all calls to_hashes. However, there are still code that populates the entirely unused_hashes.Since the plural variant covers more use cases (a file can be hashed with multiple algorithms), I restored the old logic that uses
_hashesbefore the commit, and consolidatelink_hashback into that attribute.cc @cosmicexplorer as the person that introduced
link_hash.