Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore pre 22.3 wheel cache pathing #11538

Closed
wants to merge 3 commits into from
Closed

Restore pre 22.3 wheel cache pathing #11538

wants to merge 3 commits into from

Commits on Nov 3, 2022

  1. Restore pre 22.3 wheel cache pathing 

    Prior to bad03ef wheel cache paths
incorporated source material hashes in their paths. This commit which
ended up in 22.3 stopped including that information. This is problematic
for two reasons. First our cache is no longer encoding data integrity
information that was previously intentionally included. Second it means
anyone upgrading from < 22.3 to 22.3 will have orphaned wheel cache
entries.

The fix here is to update the Link object to set Link.link_hash in the
Link.from_json method. Otherwise the hash information is simply missing.

This will cause anyone upgrading from 22.3 to newer to have orphaned
wheels, but that seems worthwile considering 22.3 hasn't been around as
long as the previous implementation and we get stronger data integrity
controls out of it.

This fixes pypa#11527
    @cboylan
    cboylan committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    a08a278 View commit details
    Browse the repository at this point in the history

  2. Add a missing loop break statement 

    This was suggested in code review.

Co-authored-by: Stéphane Bidoul <stephane.bidoul@acsone.eu>
    @cboylan @sbidoul
    cboylan and sbidoul committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    f924c00 View commit details
    Browse the repository at this point in the history

  3. Fix news entry 

    This came up in code review. It was pointed out that the news entry appears in the changelog so needs to be written for that audience.

Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
    @cboylan @uranusjr
    cboylan and uranusjr committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    46f7e5c View commit details
    Browse the repository at this point in the history