Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for failed parse log with invalid git version #10801

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Add test for failed parse log with invalid git version #10801

merged 1 commit into from
Feb 18, 2022

Conversation

Shivansh-007
Copy link
Contributor

Closes #10361

When running the linter, it removed the Unicode string prefix for some reason, not sure about that change.

@Shivansh-007
Copy link
Contributor Author

Shivansh-007 commented Jan 21, 2022

Do I need to add a changelog for this, I am not sure since this is a very much internal change, causing no changes?

Also, I can't seem to figure out why the docs CI is failing.

@pradyunsg
Copy link
Member

I think this doesn't need any changelog entries. :)

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Jan 21, 2022
@pradyunsg
Copy link
Member

#10814 will fix the docs failure. Once that is merged, you'd likely need to rebase this PR.

If you aren't familiar with rebasing PRs, you might find this article to be a helpful reference to have!

@Shivansh-007
Copy link
Contributor Author

Shivansh-007 commented Jan 21, 2022

Ok cool, yeah I am familiar with rebasing 👍🏻.

@Shivansh-007
Copy link
Contributor Author

Hey @pradyunsg could you take another look at this PR?

@Shivansh-007
Copy link
Contributor Author

Shivansh-007 commented Feb 18, 2022

Looks like #10906 is fixing the docs check failure. Will rebase when it gets merged 👍🏻

@pradyunsg
Copy link
Member

Could you rebase this? The CI issue got addressed in #10912.

@pradyunsg pradyunsg merged commit feb5fb4 into pypa:main Feb 18, 2022
@Shivansh-007 Shivansh-007 deleted the invalid-git-version-tests branch February 18, 2022 15:17
@pradyunsg
Copy link
Member

Thanks @Shivansh-007! ^>^

Do you want to try improving an error message when reading an improper METADATA file or improving the documentation for one of our CLI options?

@Shivansh-007
Copy link
Contributor Author

Shivansh-007 commented Feb 18, 2022

I am currently on break (not actually working on any code) with term-end exams, I can give 10839 a shot once I get back :)

@pradyunsg
Copy link
Member

Awesome! All the best for your exams! ^.^

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log a warning when git's version can't be parsed
3 participants