Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perform merge-conflict label checks, via GitHub Actions #10363

Merged
merged 2 commits into from Aug 15, 2021

Conversation

pradyunsg
Copy link
Member

Let's try it, and see how it works?

@uranusjr
Copy link
Member

I didn’t read the implementation; does this add a “heyyou have conflicts” comment on the PR? Because that previous behaviour was a bit annoying at times when a PR went through multiple conflicts; if the bot had to comment, it should also delete it after the conflict was resolved.

@pradyunsg
Copy link
Member Author

does this add a “heyyou have conflicts” comment on the PR?

Nope.

Because that previous behaviour was a bit annoying at times when a PR went through multiple conflicts;

I didn't quite like that behaviour either TBH. While I get the "trigger a notification to inform the author", it was usually not super useful.

I think what we'd want is the behaviour described in eps1lon/actions-label-merge-conflict#40 (different action with more capabilities). I'm subscribed there so if there's movement (or if I actually end up implementing that), then we can switch to that action and bring back the commenting behavior.

Until then, I'd prefer to stick to the simpler implementation that doesn't write any comments.

@DiddiLeija
Copy link
Member

Do you want to add a name to the workflow? Or is pradyunsg/auto-label-merge-conflicts@v3 already including a title? I just want to know.

If we are including a name like this on the YAML file:

name: Merge-conflict check # or name you like

the GitHub interface might look better, I think.

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try this out.

@pradyunsg
Copy link
Member Author

Do you want to add a name to the workflow?

Had the editor open, so I've done that.

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Aug 15, 2021
@pradyunsg pradyunsg merged commit b538f56 into pypa:main Aug 15, 2021
@pradyunsg pradyunsg deleted the merge-conflict-autolabeling branch August 15, 2021 12:25
@pradyunsg
Copy link
Member Author

pradyunsg/auto-label-merge-conflicts@v3 is not allowed to be used in pypa/pip. Actions in this workflow must be: within a repository owned by pypa, created by GitHub or match the following: actions/checkout@v2, actions/setup-python@v2, dorny/paths-filter@v2, pre-commit/action@v2.0.0.

AHAHAA. I forgot I had enabled this restriction. We'll know on the next commit to main.

For fellow maintainers wondering, https://github.com/pypa/pip/settings/actions is where the list is.

@pradyunsg
Copy link
Member Author

@DiddiLeija
Copy link
Member

What can we do now to solve this problem?

@pradyunsg
Copy link
Member Author

@DiddiLeija Thanks for taking a look. I got distracted by Mini Motorways. :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants