Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow "extra" to be None in the marker environment #650

Merged
merged 1 commit into from Dec 27, 2022
Merged

Allow "extra" to be None in the marker environment #650

merged 1 commit into from Dec 27, 2022

Conversation

pradyunsg
Copy link
Member

Closes #638

@pradyunsg pradyunsg added this to the 22.1 / 23.0 milestone Dec 26, 2022
@pradyunsg
Allow "extra" to be None in the marker environment
6385cc6 
This is for compatibility with older behaviour of this API.
@pradyunsg pradyunsg mentioned this pull request Dec 26, 2022
Closed
@rth
Copy link

rth commented Dec 26, 2022

Thanks!

@pradyunsg pradyunsg merged commit 5c70ed4 into pypa:main Dec 27, 2022
@pradyunsg pradyunsg deleted the allow-extra-none branch December 27, 2022 09:31
@pradyunsg
Copy link
Member Author

Thanks @uranusjr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr approved these changes

Assignees
No one assigned
Labels
packaging.markers
Projects
None yet
Milestone
22.1 / 23.0
Development

Successfully merging this pull request may close these issues.

Marker.evaluate with extra=None fails in 22.0
3 participants
@pradyunsg @rth @uranusjr