Change email-related fields in Metadata to str
#596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise not all valid metadata can be properly represented by `Metadata` due to the amount of flexibility allowed by RFC-822.
Closed
pradyunsg
approved these changes
Oct 5, 2022
ofek
approved these changes
Oct 5, 2022
|
@pradyunsg there aren't any tests with the constructor because there isn't anything more to the class except for the properties for getting the display and canonical names. Once the class starts to do things like consuming or producing metadata then I think we will have more tests. 😉 I also got warnings from Pylance when the names and types changed, so I would assume our mypy tests would have caught any egregious issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise not all valid metadata can be properly represented by
Metadatadue to the amount of flexibility allowed by RFC-822.For #569