Use Iterator instead of Iterable for specifier filter methods #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettcannon
approved these changes
Aug 16, 2022
| @@ -965,7 +965,7 @@ def filter( | |||
| if self._specs: | |||
| for spec in self._specs: | |||
| iterable = spec.filter(iterable, prereleases=bool(prereleases)) | |||
There was a problem hiding this comment.
This loop looks weird. Is it essentially running reduce on itself?
prereleases = bool(prereleases)
reduce_iterable = lambda it, spec: spec.filter(it, prereleases=prereleases)
yield from functools.reduce(reduce_iterable, self._specs, iterable)Not sure if it's really that much more readable, though. 😅
| @@ -965,7 +965,7 @@ def filter( | |||
| if self._specs: | |||
| for spec in self._specs: | |||
| iterable = spec.filter(iterable, prereleases=bool(prereleases)) | |||
| return iterable | |||
| return iter(iterable) | |||
There was a problem hiding this comment.
Could also do:
Suggested change
| return iter(iterable) | |
| yield from iterable |
Works in the other cases as well.
|
@pradyunsg you said you liked this idea on discuss.python.org, correct? |
|
Discord, but yes. :) Please feel welcome to land this without waiting on my review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterable is causing mypy to think next isn't supported on the return result of those methods as the Iterable protocol only requires iter. The
filterbuiltin's return type is Iterator so it (probably) makes sense to follow that.*fwiw, only
Specifier.filtersupports next as it returns a generator,SpecifierSet.filtersometimes supports next, but there are situations where it returns a list.