Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrate behaviour of SpecifierSet.__iter__ #575

Merged
merged 7 commits into from Jul 17, 2022
Merged

Demonstrate behaviour of SpecifierSet.__iter__ #575

merged 7 commits into from Jul 17, 2022

Conversation

hauntsaninja
Copy link
Contributor

Linking #573

@hauntsaninja hauntsaninja mentioned this pull request Jul 16, 2022
Closed
pradyunsg
pradyunsg reviewed Jul 16, 2022
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also include an example in the __iter__ method's docstring.

docs/specifiers.rst Outdated Show resolved Hide resolved
@hauntsaninja
Copy link
Contributor Author

Oh, I was confused about what you meant by docstring, but now I see all your changes on main :-)

@pradyunsg pradyunsg changed the title Include use of SpecifierSet.__iter__ in cheatsheet Demonstrate behaviour of SpecifierSet.__iter__ Jul 17, 2022
@pradyunsg pradyunsg merged commit 2bd5da3 into pypa:main Jul 17, 2022
@pradyunsg
Copy link
Member

Thanks @hauntsaninja! ^>^

@hauntsaninja hauntsaninja deleted the spec-docs branch July 17, 2022 22:40
@j01101111sh j01101111sh mentioned this pull request Dec 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uranusjr uranusjr uranusjr left review comments

@pradyunsg pradyunsg pradyunsg left review comments

Assignees
No one assigned
Labels
documentation packaging.specifiers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hauntsaninja @pradyunsg @uranusjr