Fix prefix version matching #560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes prefix version matching when the prospective version contains a pre-release and/or post-release and/or dev segment. This commit does not take into account pre-release and/or post-release segment in the specifier as PEP 440 is not precise enough for the behavior of such specifier and the existing code was not taking that into account either.
|
Maybe waiting on answers in https://discuss.python.org/t/pep-440-clarification-on-prefix-version-matching-with-pre-release-post-release-segments/16622 is preferable in order to fix both #559 and #425 in one go. |
|
I'll close this one pending discussions on discourse. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes prefix version matching when the prospective version contains a pre-release and/or post-release and/or dev segment.
This commit does not take into account pre-release and/or post-release segment in the specifier as PEP 440 is not precise enough for the behavior of such specifier and the existing code was not taking that into account either.
fix: #559