Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set extra in default_environment() #554

Merged
merged 1 commit into from Jun 4, 2022
Merged

Do not set extra in default_environment() #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packaging/markers.py
View file
Open in desktop
Expand Up @@ -269,7 +269,6 @@ def default_environment() -> Dict[str, str]:
iver = format_full_version(sys.implementation.version)
implementation_name = sys.implementation.name
return {
"extra": "",
"implementation_name": implementation_name,
"implementation_version": iver,
"os_name": os.name,
Expand Down Expand Up @@ -335,6 +334,7 @@ def evaluate(self, environment: Optional[Dict[str, str]] = None) -> bool:
The environment is determined from the current Python process.
"""
current_environment = default_environment()
current_environment["extra"] = ""
if environment is not None:
current_environment.update(environment)

Expand Down
1 change: 0 additions & 1 deletion tests/test_markers.py
View file
Open in desktop
Expand Up @@ -109,7 +109,6 @@ def test_matches_expected(self):
)

assert environment == {
"extra": "",
"implementation_name": sys.implementation.name,
"implementation_version": iver,
"os_name": os.name,
Expand Down