Revert "move back to setuptools (#367)" #536
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flit_core and installer are now mature enough to bootstrap themselves. Needed to enable a setuptools-free bootstrap environment and avoid circular dependencies. This reverts commit 14ad352. Signed-off-by: Charlie Li <vishwin@FreeBSD.org>
|
@pradyunsg should we accept this and do a separate port over to PEP 621? And where do you want the version to live: |
|
I'm fine with doing it in one shot or two. I have a mild preference for putting the version in |
|
@vishwin would you mind addressing the linting errors? |
|
I'll try, and probably just PEP-621 it in the process |
|
Is there any progress on this or #546? |
|
@rossburton I'm waiting to see if #546 goes anywhere before considering this PR. |
|
@brettcannon seems #546 is reasonably mature at this point, pending final review. Probabaly worth focusing on that at this point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #340, again
flit_coreandinstallerare now mature enough to bootstrap themselves. Needed to enable asetuptools-free bootstrap environment and avoid circular dependencies.This reverts commit 14ad352.
Signed-off-by: Charlie Li vishwin@FreeBSD.org