Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __hash__/__eq__ to requirements #499

Merged
merged 16 commits into from Mar 15, 2022
Merged

Add __hash__/__eq__ to requirements #499

merged 16 commits into from Mar 15, 2022

Commits on Mar 15, 2022

  1. Make Requirement hashable

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    b8b127b View commit details
    Browse the repository at this point in the history

  2. Add tests for hashable/comparable requirements

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    17c7d93 View commit details
    Browse the repository at this point in the history

  3. Document comparisons between requirement objects

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    d4976f3 View commit details
    Browse the repository at this point in the history

  4. Fix misspelling in docs/requirements.rst 

    Co-authored-by: Brett Cannon <brett@python.org>
    @abravalheri @brettcannon
    abravalheri and brettcannon committed Mar 15, 2022
    Copy the full SHA
    8bcac29 View commit details
    Browse the repository at this point in the history

  5. Make markers hashable/comparable

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    61929e6 View commit details
    Browse the repository at this point in the history

  6. Replace string comparison with attributes for requirements

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    cdd6569 View commit details
    Browse the repository at this point in the history

  7. Document comparisons between marker objects

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    1473075 View commit details
    Browse the repository at this point in the history

  8. Allow comparison between subclasses of Requirement and Marker

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    85f8403 View commit details
    Browse the repository at this point in the history

  9. Update docs/requirements.rst 

    Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
    @abravalheri @pradyunsg
    abravalheri and pradyunsg committed Mar 15, 2022
    Copy the full SHA
    dad5903 View commit details
    Browse the repository at this point in the history

  10. Update docs/markers.rst

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    c32d640 View commit details
    Browse the repository at this point in the history

  11. Remove unecessary type cast

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    0d97221 View commit details
    Browse the repository at this point in the history

  12. Test hashes directly

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    295f2c3 View commit details
    Browse the repository at this point in the history

  13. Use string comparisson for markers instead of flattening

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    e94fce0 View commit details
    Browse the repository at this point in the history

  14. Separate tests comparing objects to markers and requirements

    @abravalheri
    abravalheri committed Mar 15, 2022
    Copy the full SHA
    0a6559f View commit details
    Browse the repository at this point in the history

  15. Apply suggestions from code review 

    Co-authored-by: Brett Cannon <brett@python.org>
    @abravalheri @brettcannon
    abravalheri and brettcannon committed Mar 15, 2022
    Copy the full SHA
    ed0c623 View commit details
    Browse the repository at this point in the history

  16. Tweak grammar in a comment

    @brettcannon
    brettcannon committed Mar 15, 2022
    Copy the full SHA
    5feae24 View commit details
    Browse the repository at this point in the history