Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pyparsing>=3.0.0 #480

Closed
wants to merge 5 commits into from
Closed

Update to pyparsing>=3.0.0 #480

wants to merge 5 commits into from

Commits on Oct 30, 2021

  1. Bump pyparsing, update usages and update UT

    Add support to `pyparsing>=3.0.0`.
    Changes required:
    - `originalTextFor` -> `original_text_for`
    - `stringEnd` -> `string_end`
    - `stringStart` -> `string_start`
    
    Update UT: `test_parseexception_error_msg` to check for `string_end`
    instead of `stringEnd` in exception message.
    moyiz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    0039779 View commit details
    Browse the repository at this point in the history
  2. session.install for lint

    Install current `packaging` and its dependencies during lint.
    `nox` depends on `packaging`, by installing `nox` during lint phase,
    `packaging` dependencies defined in working branch are overridden by
    latest `packaging` release dependencies.
    In this case, since the PR changes the constraints on `pyparsing`,
    without a `session.install(".")` the incorrect `pyparsing` version will
    be installed.
    moyiz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    478d8a0 View commit details
    Browse the repository at this point in the history
  3. Install current packaging before build

    This ensures that we install the dependencies of current working branch
    of `packaging`.
    Similar to previous commit. `build` package depends on `packaging` and
    installing it overrides the dependencies of current working branch by
    the dependencies of latest `packaging` release.
    moyiz committed Oct 30, 2021
    Configuration menu
    Copy the full SHA
    b8e9b5c View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2021

  1. Remove re-installation in favor of stateless build

    See: https://github.com/pypa/packaging/pull/480/files#r740158146
    
    As suggested by @layday, local `packaging` package directory takes
    precedence over the installed `packaging`. By building with
    `pyproject-build`, CWD will not be added to python path.
    moyiz committed Nov 1, 2021
    Configuration menu
    Copy the full SHA
    c319f2a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45cf08f View commit details
    Browse the repository at this point in the history