Update PyPy CI Specifier #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattip
force-pushed
the
pypy-ci
branch
2 times, most recently
from
90bf597
to
d4887f1
Compare
|
I am not well-versed in nox. The github setup-python specifier is now pypy-3.7, the executable in the created environment can be one of pypy3, pypy3.7, pypy, python, python3, or python3.7. Is nox looking for pypy-3.7? That is not one of the options. |
pradyunsg
approved these changes
Oct 14, 2021
mattip
force-pushed
the
pypy-ci
branch
3 times, most recently
from
f3a47ad
to
7400644
Compare
pradyunsg
reviewed
Oct 14, 2021
|
Adding another |
pradyunsg
reviewed
Oct 14, 2021
In the end the old invocation was correct Co-authored-by: Pradyun Gedam <pradyunsg@gmail.com>
|
You didn't modify any .py files, so the required runs aren't running anymore. 🤣 It's fine though -- I can tick the admin checkbox and merge this. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pypy3is being deprecated as a specifier, see actions/setup-python#244. Right now this affects macos-latest, but I imagine it will percolate through the other os images as well. The current CI here has not failed, I think because the image is cached.