Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pypy github action #243

Merged
merged 9 commits into from
Dec 2, 2019
Merged

Adding pypy github action #243

merged 9 commits into from
Dec 2, 2019

Conversation

Sangarshanan
Copy link
Contributor

@Sangarshanan Sangarshanan commented Nov 28, 2019

Closes #235

Opening a cleaner PR with some changes suggested by @pradyunsg

@brettcannon
Copy link
Member

@Sangarshanan do you mind editing a Python file to trigger the workflow so we can see how it works out? Like fix a spelling mistake in a docstring or just tweak a .py file slightly which is easy to revert before we merge?

Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just holding up until we can see a run to make sure there isn't anything like YAML errors (which has happened to me when working on action files 😁).

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@Sangarshanan
Copy link
Contributor Author

Not sure as to why there are no logs for these failures

@pradyunsg
Copy link
Member

FYI -- there's a button on the UI for GitHub checks ("Rerun all checks") that I just pressed.

@brettcannon
Copy link
Member

@Sangarshanan Maybe try working backwards by scaling back the pypy job run-by-run and see if that changes anything?

@pradyunsg the re-run still leads to no output unfortunately :/

@Sangarshanan
Copy link
Contributor Author

Sangarshanan commented Nov 29, 2019

Just figured out that it was an issue with the pytest faulthandler pytest-dev/pytest#5807

Downgraded the Pytest version and the tests have run successfully : )

@brettcannon brettcannon self-requested a review November 29, 2019 19:47
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job figuring out the problem! I just want to make sure it's recorded as to why an old version of pytest is needed (for now) so people don't unpin it until a fix is out.

.github/workflows/test.yml Outdated Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
@Sangarshanan
Copy link
Contributor Author

Thanks for being awesome and helping me out @brettcannon < 3

@Sangarshanan
Copy link
Contributor Author

Do I need to make any more changes @brettcannon @pradyunsg ?

@brettcannon brettcannon merged commit 6a09d40 into pypa:master Dec 2, 2019
@brettcannon
Copy link
Member

@Sangarshanan nope, just had to wait until one of had time to review it one last time.

Thanks for making this happen!

@aixtools
Copy link

aixtools commented Dec 9, 2019

Hi. While to update #190 I got an error from pypy testing. Not understanding how my patch was breaking things - I opened a new scratch PR that I was going to use to slowly add things to see when it broke. But I see that "master" is not passing for me - which do not understand because this PR #243 did pass all tests.

Anyway - my scratch #244 fails with https://github.com/pypa/packaging/pull/244/checks?check_run_id=339889206 Please consider reverting this addition - as I am stumped (not that my being stumped has any importance - :) - I would be extremely appreciative in any case!)

@brettcannon
Copy link
Member

@aixtools (un)fortunately master still passes untouched with this PR so reverting it for another PR doesn't seem prudent to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add PyPy to GitHub Actions
4 participants