-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding pypy github action #243
Conversation
@Sangarshanan do you mind editing a Python file to trigger the workflow so we can see how it works out? Like fix a spelling mistake in a docstring or just tweak a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just holding up until we can see a run to make sure there isn't anything like YAML errors (which has happened to me when working on action files 😁).
Co-Authored-By: Brett Cannon <54418+brettcannon@users.noreply.github.com>
Not sure as to why there are no logs for these failures |
FYI -- there's a button on the UI for GitHub checks ("Rerun all checks") that I just pressed. |
@Sangarshanan Maybe try working backwards by scaling back the pypy job run-by-run and see if that changes anything? @pradyunsg the re-run still leads to no output unfortunately :/ |
Just figured out that it was an issue with the pytest faulthandler pytest-dev/pytest#5807 Downgraded the Pytest version and the tests have run successfully : ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job figuring out the problem! I just want to make sure it's recorded as to why an old version of pytest is needed (for now) so people don't unpin it until a fix is out.
Thanks for being awesome and helping me out @brettcannon < 3 |
Do I need to make any more changes @brettcannon @pradyunsg ? |
@Sangarshanan nope, just had to wait until one of had time to review it one last time. Thanks for making this happen! |
Hi. While to update #190 I got an error from pypy testing. Not understanding how my patch was breaking things - I opened a new scratch PR that I was going to use to slowly add things to see when it broke. But I see that "master" is not passing for me - which do not understand because this PR #243 did pass all tests. Anyway - my scratch #244 fails with https://github.com/pypa/packaging/pull/244/checks?check_run_id=339889206 Please consider reverting this addition - as I am stumped (not that my being stumped has any importance - :) - I would be extremely appreciative in any case!) |
@aixtools (un)fortunately |
Closes #235
Opening a cleaner PR with some changes suggested by @pradyunsg