Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest python-docs-theme #1116

Merged
merged 3 commits into from Jul 30, 2022
Merged

Conversation

bhrutledge
Copy link
Contributor

On at least Chrome and Safari on macOS, the rendering of directory trees are hard to read:

Screen Shot 2022-07-30 at 7 29 21 AM

Noting that the pypa_theme inherits from python_docs_theme, I poked around on the Python docs and discovered that it's not an issue there. That led me to python/python-docs-theme#87, which was released in 2021.11.1. Sure enough, upgrading fixes the output:

Screen Shot 2022-07-30 at 7 34 31 AM

This also includes "Make sidebar scrollable and sticky (on modern browsers)", which I think is a nice enhancement.

@bhrutledge bhrutledge requested a review from webknjaz July 30, 2022 11:38
@bhrutledge bhrutledge mentioned this pull request Jul 30, 2022
@webknjaz webknjaz enabled auto-merge July 30, 2022 20:04
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like GH doesn't let me resolve the conflict in my browser (maybe it's a Refined GitHub's bug). So you'll need to do that yourself.

@webknjaz webknjaz merged commit 612d426 into pypa:main Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants