Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show hash values of files to be uploaded #87

Merged
merged 11 commits into from Jan 9, 2022
Merged

Show hash values of files to be uploaded #87

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e5cc29f
Show hash values of files uploaded
dukecat0 Jan 7, 2022
77ee113
Move out the Python script from the shell script
dukecat0 Jan 8, 2022
fc71be6
Add print-hash.py to Dockerfile
dukecat0 Jan 8, 2022
06a2dd6
Fix bug
dukecat0 Jan 8, 2022
ca30c7d
Show a message before printing hash values of files
dukecat0 Jan 8, 2022
777bfc4
Fix the message
dukecat0 Jan 8, 2022
c83d37b
Introduce print_hash in README
dukecat0 Jan 8, 2022
8682135
Correct the if-clause for printing the hashes
webknjaz Jan 8, 2022
0575dc8
Refactor the hash helper script to use pathlib and CLI args
webknjaz Jan 8, 2022
5d18baa
Drop unnecessary `file_iterable` var
webknjaz Jan 8, 2022
977d067
Fix a bug
dukecat0 Jan 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions action.yml
View file
Open in desktop
Expand Up @@ -30,6 +30,10 @@ inputs:
description: Show verbose output.
required: false
default: false
print_hash:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that maybe it's better to make this plural. But it's too late now so I'll keep it as is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change of the public API. We'd have to wait until v2 or even v3 depending on how we decide to do deprecation. There are other things, I'd change like using kebab-case for the inputs but not today.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, and I just realized that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may add a print_hashes, and treat the current name as an undocumented alias.

description: Show hash values of files uploaded
required: false
default: false
branding:
color: yellow
icon: upload-cloud
Expand All @@ -44,3 +48,4 @@ runs:
- ${{ inputs.verify_metadata }}
- ${{ inputs.skip_existing }}
- ${{ inputs.verbose }}
- ${{ inputs.print_hash }}
26 changes: 26 additions & 0 deletions twine-upload.sh
View file
Open in desktop
Expand Up @@ -48,3 +48,29 @@ TWINE_USERNAME="$INPUT_USER" \
TWINE_PASSWORD="$INPUT_PASSWORD" \
TWINE_REPOSITORY_URL="$INPUT_REPOSITORY_URL" \
exec twine upload ${TWINE_EXTRA_ARGS} ${INPUT_PACKAGES_DIR%%/}/*

if [[ ${INPUT_PRINT_HASH,,} != "false" ]] ; then
dukecat0 marked this conversation as resolved.
Show resolved Hide resolved
cat > ./print_hash.py << EOF
import os
import hashlib
sha256 = hashlib.sha256()
md5 = hashlib.md5()
blake2_256 = hashlib.blake2b(digest_size=256 // 8)
file_list = os.listdir(os.path.abspath("${INPUT_PACKAGES_DIR%%/}"))
for i in file_list:
print(i)
print("")
file = open(os.path.abspath(os.path.join("${INPUT_PACKAGES_DIR%%/}", i)), "rb")
content = file.read()
file.close()
sha256.update(content)
md5.update(content)
blake2_256.update(content)
print(f"SHA256: {sha256.hexdigest()}")
print(f"MD5: {md5.hexdigest()}")
print(f"BLAKE2-256: {blake2_256.hexdigest()}")
print("")
EOF
python ./print_hash.py
rm ./print_hash.py
fi