Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit mutating global state #233

Merged
merged 9 commits into from
Mar 2, 2024
Merged

Limit mutating global state #233

merged 9 commits into from
Mar 2, 2024

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Mar 2, 2024

  • Extract a method for customizing the compiler for macOS.
  • Convert comment to docstring; update wording.
  • Create a fixture to patch-out compiler customization on macOS.
  • Utilize the fixture for disabling compiler customization on macOS for cxx test. Closes Test suite is brittle around global sysconfig._config_vars state. #231.
  • Limit mutating global state and simply rely on functools.lru_cache to limit the behavior to a single invocation.

@jaraco jaraco merged commit 5b74c86 into main Mar 2, 2024
31 of 32 checks passed
@jaraco jaraco deleted the quality/231-global-state branch March 2, 2024 15:36
jaraco added a commit that referenced this pull request Mar 2, 2024
@jaraco
Merge pull request #233 from pypa/quality/231-global-state
832bdd9 
Limit mutating global state
@jaraco jaraco restored the quality/231-global-state branch March 2, 2024 15:38
@jaraco jaraco deleted the quality/231-global-state branch March 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test suite is brittle around global sysconfig._config_vars state.
1 participant
@jaraco