Suppress OSError when searching config files #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FFY00
force-pushed
the
fix-oserror-config-files
branch
from
8e3f32f
to
d6adb6d
Compare
Fixes pypa#181 Signed-off-by: Filipe Laíns <lains@riseup.net>
FFY00
force-pushed
the
fix-oserror-config-files
branch
from
d6adb6d
to
83fb38f
Compare
|
Thanks for the PR. I specifically aimed to avoid the init/for/append construct, so I'd like not to re-introduce that. Also, I wonder if this bug deserves a regression test (so the fix isn't optimized away). I'm tempted to recommend just going back to |
|
In be45b47, I've added an xfailing test. |
|
Ugh. That test is no good. The permission error is coming from the setup and not the find_config_files call. |
|
The proposed change is superseded by e1fe8bd. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #181
Signed-off-by: Filipe Laíns lains@riseup.net