refactor: Use utils.call & utils.shell in macos.py & windows.py #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
refactor-call
branch
from
da107f8
to
5b85182
Compare
joerick
reviewed
Dec 31, 2021
mayeut
force-pushed
the
refactor-call
branch
2 times, most recently
from
406bafc
to
813c72e
Compare
joerick
approved these changes
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #672, uses an implementation like the one in #672 (comment)
Extracted from #974
It might be easier to review this one on its own. I'll rebase #974 on this one.