Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Python 3.13 beta 1 #1815

Merged
merged 1 commit into from May 12, 2024
Merged

feat: add Python 3.13 beta 1 #1815

merged 1 commit into from May 12, 2024

Conversation

mayeut
Copy link
Member

@mayeut mayeut commented May 9, 2024

Let's try to start building with python 3.13

@henryiii
Copy link
Contributor

henryiii commented May 9, 2024

AssertionError: would build wheel with unsupported tag ('cp313', 'cpwin32', 'win32')

(Coming from wheel) @agronholm, does this need a new release of wheel? I thought the only thing missing was free-threading (which we are not adding yet).

Edit: This should be supported in wheel 0.43.

@agronholm
Copy link

Tag parsing is done via the vendored packaging library, and I explicitly made the 0.43.0 release to incorporate that in wheel.

@agronholm
Copy link

Can you confirm which version of wheel was even used? Where does the test suite install that?

@henryiii
Copy link
Contributor

henryiii commented May 10, 2024

It seems to be only on Windows, and it's (at least) these four tests:

FAILED test/test_0_basic.py::test[pip] - subprocess.CalledProcessError: Command '['C:\\hostedtoolcache\\windows\\Python\\3.12.3\\x64\\python.exe', '-m', 'cibuildwheel', '--prerelease-pythons', '--output-dir', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpu5qo0yto', '.']' returned non-zero exit status 1.
FAILED test/test_before_all.py::test_cwd - subprocess.CalledProcessError: Command '['C:\\hostedtoolcache\\windows\\Python\\3.12.3\\x64\\python.exe', '-m', 'cibuildwheel', '--prerelease-pythons', '--output-dir', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpdb__fxb6', '.']' returned non-zero exit status 1.
FAILED test/test_before_build.py::test_cwd - subprocess.CalledProcessError: Command '['C:\\hostedtoolcache\\windows\\Python\\3.12.3\\x64\\python.exe', '-m', 'cibuildwheel', '--prerelease-pythons', '--output-dir', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpbhu69bgj', '.']' returned non-zero exit status 1.
FAILED test/test_before_all.py::test - subprocess.CalledProcessError: Command '['C:\\hostedtoolcache\\windows\\Python\\3.12.3\\x64\\python.exe', '-m', 'cibuildwheel', '--prerelease-pythons', '--output-dir', 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpugwbyfy3', '.']' returned non-zero exit status 1.

I see a (3.12) venv seeded with 0.37.1, though the isolated build shouldn't pick up this cached version from what I understand. I think it's only failing on Windows, I'm rerunning with fail-fast off to check, though.

@mayeut
Copy link
Member Author

mayeut commented May 10, 2024

The issue comes from cibuildwheel.
The environment is pre-seeded, there's no pin on setuptools / wheel anymore (9879937) but the project does not have a pyproject.toml so pre-seeded with outdated versions is used.

Reproduced there: https://github.com/mayeut/sandbox/actions/runs/9029260391

@mayeut
Copy link
Member Author

mayeut commented May 10, 2024

@henryiii, I'll force push and overwrite your commits with something else.

@mayeut mayeut force-pushed the python-3.13 branch 3 times, most recently from df7e3ad to 0d88011 Compare May 10, 2024 08:51
@mayeut
Copy link
Member Author

mayeut commented May 10, 2024

maybe we ought to get the fixes / changes in the last 3 commits in another PR to discuss those changes ?

@henryiii
Copy link
Contributor

Might make sense, yes. I don't think we should be injecting or pinning setuptools/wheel; if someone is building on Python 3.12 or 3.13 and doesn't have a pyproject.toml, I think they should be required to pip install setuptools and wheel in CIBW_BEFORE_BUILD. (Or add a pyproject.toml).

@mayeut mayeut marked this pull request as draft May 10, 2024 17:40
@mayeut mayeut force-pushed the python-3.13 branch 2 times, most recently from 134d464 to 5a30236 Compare May 11, 2024 05:41
@mayeut mayeut marked this pull request as ready for review May 11, 2024 21:33
@henryiii henryiii merged commit 44c4742 into pypa:main May 12, 2024
19 of 20 checks passed
@mayeut mayeut deleted the python-3.13 branch May 12, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants