-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor error handling to use exceptions #1719
Open
joerick
wants to merge
7
commits into
main
Choose a base branch
from
error-exceptions
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Dec 30, 2023
-
Refactor error handling to use exceptions
cibuildwheel has up until now handled most errors by printing an error message to sys.stderr and calling sys.exit. Others were handled using Logger.error, depending on the context. We also had return codes, but these weren't explicitly defined anywhere. This makes that convention more explicit and codified. Now to halt the program, the correct thing to do is to throw a cibuildwheel.errors.FatalError exception - that is caught in main() and printed before exiting. The existing behaviour was kept - if an error occurs within a build step (probably something to do with the build itself), the Logger.error() method is used. Outside of a build step (e.g. a misconfiguration), the behaviour is still to print 'cibuildwheel: <message>' I also took the opportunity to add a debugging option `--debug-traceback` (and `CIBW_DEBUG_TRACEBACK`), which you can enable to see a full traceback on errors. (I've deactivated the flake8-errmsg lint rule, as it was throwing loads of errors and these error messages aren't generally seen in a traceback context)
Configuration menu - View commit details
-
Copy full SHA for 736931a - Browse repository at this point
Copy the full SHA 736931aView commit details
Commits on Jan 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8f0f4ba - Browse repository at this point
Copy the full SHA 8f0f4baView commit details
Commits on Jan 19, 2024
-
Apply suggestions from code review
Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 403a132 - Browse repository at this point
Copy the full SHA 403a132View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2631626 - Browse repository at this point
Copy the full SHA 2631626View commit details
Commits on Jan 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 46e437d - Browse repository at this point
Copy the full SHA 46e437dView commit details
Commits on Mar 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for dc60bf8 - Browse repository at this point
Copy the full SHA dc60bf8View commit details -
Configuration menu - View commit details
-
Copy full SHA for aab0195 - Browse repository at this point
Copy the full SHA aab0195View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.