chore: minor cleanup #1475
Merged
chore: minor cleanup #1475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
commented
Apr 17, 2023
| @@ -256,6 +256,7 @@ def build(self, options: Options, tmp_path: Path) -> None: | |||
| ... | |||
|
|
|||
|
|
|||
| # pylint: disable-next=inconsistent-return-statements | |||
| def get_platform_module(platform: PlatformName) -> PlatformModule: | |||
There was a problem hiding this comment.
FYI, I think the need for RET 503 below might be a bug in Ruff: astral-sh/ruff#3304
There was a problem hiding this comment.
It's been fixed, the noqa can go away in the next Ruff release :)
joerick
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a bit of cleanup from looking at #1297 again. Drops the unmaintained
[mypy]extra.