chore: Add a PlatformModule type #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
platform-interface
branch
from
5b33087
to
e9333a7
Compare
mayeut
approved these changes
Apr 8, 2023
|
Could someone merge this? |
This avoids the repetition of the platform checks in __main__.py by defining a dataclass with `get_python_configurations` and `build`.
hoodmane
force-pushed
the
platform-interface
branch
from
e9333a7
to
26dd3f3
Compare
|
I've just been playing with this and I think it would be simpler to use the module itself as the 'interface' object. We can type it with a Protocol I believe, like so class PlatformModule(typing.Protocol):
# note that as per PEP544, the self argument is ignored when the protocol
# is applied to a module
def get_python_configurations(self, build_selector: BuildSelector, architectures: Set[Architecture]) -> typing.Sequence[GenericPythonConfiguration]:
...
def build(self, options: Options, tmp_path: Path) -> None:
... |
henryiii
reviewed
Apr 10, 2023
|
I have a version that looks to be working locally, I can push here if you like? |
|
I'm off to bed so I've pushed that, hope that's okay. I think it's a bit simpler without the extra object. |
hoodmane
commented
Apr 10, 2023
|
|
||
| def get_platform_module(platform: PlatformName) -> PlatformModule: | ||
| if platform == "linux": | ||
| return cibuildwheel.linux |
There was a problem hiding this comment.
Nice! I did not realize you could do this.
There was a problem hiding this comment.
When I tried, I left out the self parameter and got complaints.
joerick
changed the title
joerick
changed the title
joerick
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids the repetition of the platform checks in main.py by defining a dataclass with
get_python_configurationsandbuild.