[pre-commit.ci] pre-commit autoupdate

[pre-commit-ci]

updates:

• github.com/charliermarsh/ruff-pre-commit: v0.0.249 → v0.0.253

[henryiii]

Personally think at least one of those was a false positive. astral-sh/ruff#3022

[Czaki]

for me both look like false positives as "normalization" of data is a common pattern, but I do not have any idea for heuristics that could be good here.

[henryiii]

The second was intended by the PR (even though I don't think it's very helpful), while I don't think the first was.

IMO, I wouldn't expect "with" to create scope, so personally I'd disable this part of the check, but the original check was useful, and it's all or nothing, since it's all the same code. It's only two hits in cibuildwheel, but I'm worried it's more other places. We'll see. It's not that hard to work around, so I'll probably live with it.

[henryiii]

It's not due to the with - reassignments in loops of any sort are actually not allowed. This helps in several common cases (like nested for loops over the same variable), so I think it's fine to use the current workaround.