Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear up that BEFORE_ALL runs outside of Python env #1147

Merged
merged 2 commits into from Jul 15, 2022
Merged

Clear up that BEFORE_ALL runs outside of Python env #1147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8afef34
Clear up that BEFORE_ALL runs outside of Python env
abitrolly Jun 19, 2022
40f92bd
Proposal to improve this doc entry
joerick Jul 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/options.md
View file
Open in desktop
Expand Up @@ -635,7 +635,7 @@ To specify more than one environment variable, separate the variable names by sp
### `CIBW_BEFORE_ALL` {: #before-all}
> Execute a shell command on the build system before any wheels are built.

Shell command to prepare a common part of the project (e.g. build or install libraries which does not depend on the specific version of Python).
Shell command that runs before creating Python environment, to build or install parts that do not depend on the specific version of Python.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Shell command that runs before creating Python environment, to build or install parts that do not depend on the specific version of Python.
Shell command to prepare a common part of the project (e.g. build or install libraries which does not depend on the specific version of Python). This runs before creating the Python environments for each build.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If a "common part of the project" doesn't include pieces that are shared between operating system environments, it is better to leave this scope escape off to avoid bloating the description beyond that is mere necessary.


This option is very useful for the Linux build, where builds take place in isolated Docker containers managed by cibuildwheel. This command will run inside the container before the wheel builds start. Note, if you're building both `x86_64` and `i686` wheels (the default), your build uses two different Docker images. In that case, this command will execute twice - once per build container.

Expand Down