Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert pypy 3.7 to 7.3.7 #1035

Closed
wants to merge 2 commits into from
Closed

fix: revert pypy 3.7 to 7.3.7 #1035

wants to merge 2 commits into from

Conversation

henryiii
Copy link
Contributor

See #1031

@henryiii henryiii mentioned this pull request Feb 24, 2022
@henryiii
Copy link
Contributor Author

For consistency, how about just rolling it back to consistently be 7.3.7 everywhere until manylinux and the issue with PyPy are fixed (probably in a 7.3.9)?

@henryiii
Copy link
Contributor Author

henryiii commented Feb 24, 2022

Update: no, it looks like 3.9 is ready to go, so we could do 7.3.7 for 3.7, and 7.3.8 for 3.8 & 3.9. That would be fine.
Edit again: Forgot about manylinux, that won't have mixed PyPy versions, so back to liking consistent PyPy versions.

@mayeut
Copy link
Member

mayeut commented Feb 24, 2022

@henryiii, manylinux is only rolling back 3.7 to 7.3.7: pypa/manylinux#1289

Update: no, it looks like 3.9 is ready to go, so we could do 7.3.7 for 3.7, and 7.3.8 for 3.8 & 3.9. That would be fine.

That plan works IMHO

@henryiii
Copy link
Contributor Author

Happy to follow manylinux. We'll need a bump to the new manylinux images, so maybe we should just do everything in #1031.

@mayeut
Copy link
Member

mayeut commented Feb 24, 2022

We'll need a bump to the new manylinux images, so maybe we should just do everything in #1031.

I was just about to propose that !

@henryiii henryiii closed this Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants