feature: allow local runs on windows/macOS #974
Merged
+505
−230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayeut
force-pushed
the
python-cache3
branch
3 times, most recently
from
15dde4a to
583d5f7
Compare
henryiii
reviewed
Dec 29, 2021
joerick
reviewed
Dec 29, 2021
mayeut
force-pushed
the
python-cache3
branch
from
810c5a7 to
d048d8e
Compare
mayeut
commented
Dec 30, 2021
mayeut
force-pushed
the
python-cache3
branch
6 times, most recently
from
61380e6 to
3c6d509
Compare
Cache python installations to a user cache folder using platformdirs. The build environment is now a virtual environment to allow proper isolation. Allows to run tests in parallel.
joerick
reviewed
Jan 7, 2022
That looks good thanks. |
joerick
added a commit
that referenced
this pull request
Jan 21, 2024
Historically, we required `--platform` when running cibuildwheel outside of CI, because cibuildwheel would attempt to globally install Python interpreters and some packages. That was fixed in #974 a couple of years ago. As a result, there's no reason to require --platform these days, the `auto` behaviour is perfectly fine for dev machines. It also makes running tests locally simpler, one can just do `pytest test/test_0_basic.py` (or `nox -s tests -- test/test_0_basic.py`) and not have to worry about setting CIBW_PLATFORM most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specific for macOS:
The python.org installers are still installed globally, only one
{major}.{minor}is allowed to be installed at a time.The way this is handled does not change with this PR meaning that there might be a mismatch between the installed python version and the one expected by cibuildwheel.
Given shudoers right are necessary to do the installation, in order for local runs to work, the user still has to install the relevant python versions manually.
Edit by joerick: Fixes #104