Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitLab support #1295

Merged
merged 9 commits into from Oct 12, 2022
Merged

Update GitLab support #1295

merged 9 commits into from Oct 12, 2022

Conversation

wbarnha
Copy link
Contributor

@wbarnha wbarnha commented Oct 6, 2022

Closes #1294

@wbarnha wbarnha changed the title Update support for Linux ARM on GitLab Update GitLab support Oct 7, 2022
@joerick
Copy link
Contributor

joerick commented Oct 7, 2022

Ah, Gitlab supports windows now? Could you add a job to our .gitlab-ci.yml so that we run our tests on that platform too?

It might also be good to run an emulation test on Gitlab, we already have a test like that configured on GHA, that could be replicated there. Not essential though, it would depend on how much CI time it eats up I reckon.

@joerick
Copy link
Contributor

joerick commented Oct 7, 2022

Examples test run

Branch: example-config-test---extend-gitlab-qemu-2022-10-07T08-19-37

Service Config Status
gitlab examples/gitlab-with-qemu.yml Gitlab

Generated by bin/run_example_ci_config.py

@joerick
Copy link
Contributor

joerick commented Oct 7, 2022

Been a while since we tested the minimals, lets see if there are any gremlins lurking...

Examples test run

Branch: example-config-test---extend-gitlab-qemu-2022-10-07T08-25-31

Service Config Status
circleci examples/circleci-minimal.yml CircleCI
gitlab examples/gitlab-minimal.yml Gitlab
travis-ci examples/travis-ci-minimal.yml Build Status
appveyor examples/appveyor-minimal.yml Build status
azure-pipelines examples/azure-pipelines-minimal.yml Build Status
github examples/github-minimal.yml Build
cirrus-ci examples/cirrus-ci-minimal.yml Cirrus CI

Generated by bin/run_example_ci_config.py

edit: there are some other gremlins. I'll address these in a separate PR.

@wbarnha
Copy link
Contributor Author

wbarnha commented Oct 7, 2022

Ah, Gitlab supports windows now? Could you add a job to our .gitlab-ci.yml so that we run our tests on that platform too?

Done, not 100% sure if it'll work properly though.

I'm also waiting to hear back on GitLab for access to macOS runner to find out if my example can build wheels for macOS. Not sure how long that will take so feel free to merge this in and I'll create another MR when I get that working.

@joerick joerick merged commit d7f615a into pypa:main Oct 12, 2022
@joerick
Copy link
Contributor

joerick commented Oct 12, 2022

Thanks @wbarnha!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend support for more architectures on GitLab
3 participants