New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: disable colorama
on Linux and flush output
#494
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
6231afc
Disable `colorama` on Linux (fixes #493)
abitrolly 3c2e668
`colorama` is a required dependency on Windows
abitrolly f75a29c
Prevent output buffering
abitrolly 753e8ff
Fix `cprint()`
abitrolly c2ad8c1
Make `cprint()` private
abitrolly 97dd2aa
Get back `ModuleNotFoundError`
abitrolly 31bc4f1
`cprint`: don't try to format message
abitrolly b589716
Add type annotation
abitrolly ec960b2
tests: remove colorama on path test
henryiii c6dc62f
tests: move path test up to normal tests
henryiii 4fa3086
tox: include coverage on path job
henryiii a1ccc27
ci: combine coverage from the run
henryiii File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I just noticed the flush=True. I was going to do a follow up PR since I noticed that build's output can get mangled with the build system's output if it goes to stderr. But there's a flush here already! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because Python default output buffering is evil )
#494 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely no argument there!!! Dealing with this in cibuildwheel, scikit-build, etc.