chore: update changelog, minor touchups #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
commented
May 12, 2022
| print('{red}ERROR{reset} {}'.format(msg, **_STYLES)) | ||
| exit(code) | ||
| print('{red}ERROR{reset} {}'.format(msg, **_STYLES), file=sys.stderr) | ||
| raise SystemExit(code) |
There was a problem hiding this comment.
exit() is not part of the language, it's injected by site.py. Better to use sys.exit(), or even better, just raise SystemExit directly.
henryiii
commented
May 12, 2022
| ] | ||
|
|
||
|
|
||
| def __dir__() -> List[str]: |
There was a problem hiding this comment.
Makes tab completion prettier on Python 3.7+.
layday
approved these changes
May 12, 2022
|
I assume the tests are failing because errors are printed to |
henryiii
commented
May 12, 2022
Co-authored-by: layday <layday@protonmail.com> Apply suggestions from code review tests: add test for coverage
henryiii
force-pushed
the
henryiii/chore/changelog
branch
from
2eb4794
to
76c30c9
Compare
|
Added a test for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few fixes and cleanups.
IsolatedEnv#361