Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env._find_executable_and_scripts(): Prefer the venv installation scheme if it exists #434

Merged
merged 3 commits into from Mar 18, 2022
Merged

env._find_executable_and_scripts(): Prefer the venv installation scheme if it exists #434

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
211bd2f
env._find_executable_and_scripts(): Prefer the venv installation sche…
hroncok Jan 31, 2022
3c08a32
Save and reuse sysconfig.get_scheme_names()
hroncok Jan 31, 2022
512f1fb
Fixup: Move each part of the comment to its relevant if/elif clause
hroncok Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 15 additions & 8 deletions src/build/env.py
View file
Open in desktop
Expand Up @@ -293,14 +293,21 @@ def _find_executable_and_scripts(path: str) -> Tuple[str, str, str]:
"""
config_vars = sysconfig.get_config_vars().copy() # globally cached, copy before altering it
config_vars['base'] = path
# The Python that ships with the macOS developer tools varies the
# default scheme depending on whether the ``sys.prefix`` is part of a framework.
# The framework "osx_framework_library" scheme
# can't be used to expand the paths in a venv, which
# can happen if build itself is not installed in a venv.
# If the Apple-custom "osx_framework_library" scheme is available
# we enforce "posix_prefix", the venv scheme, for isolated envs.
if 'osx_framework_library' in sysconfig.get_scheme_names():
scheme_names = sysconfig.get_scheme_names()
if 'venv' in scheme_names:
# Python distributors with custom default installation scheme can set a
# scheme that can't be used to expand the paths in a venv.
# This can happen if build itself is not installed in a venv.
# The distributors are encouraged to set a "venv" scheme to be used for this.
# See https://bugs.python.org/issue45413
# and https://github.com/pypa/virtualenv/issues/2208
paths = sysconfig.get_paths(scheme='venv', vars=config_vars)
elif 'osx_framework_library' in scheme_names:
# The Python that ships with the macOS developer tools varies the
# default scheme depending on whether the ``sys.prefix`` is part of a framework.
# But it does not (yet) set the "venv" scheme.
# If the Apple-custom "osx_framework_library" scheme is available but "venv"
# is not, we use "posix_prefix" instead which is venv-compatible there.
paths = sysconfig.get_paths(scheme='posix_prefix', vars=config_vars)
else:
paths = sysconfig.get_paths(vars=config_vars)
Expand Down