Accept os.PathLike in addition to str for paths in public API

[bfgray3]

closes #372

[FFY00]

Do from __future__ import annotations instead.

[henryiii]

Python 3.6 hasn't hit EoL.

Besides, they are talking about deprecating that in 3.11 and removing it in 3.13. 😠

[FFY00]

Ah 😕

Yeah, it will likely be replaced by co_annotations, but I haven't been following the progress closely.

[FFY00]

We might have to do a version check here actually.

[henryiii]

I think it's safe to do a string inside this, it'll be a ForwardRef. Also, from __future__ import annotations wouldn't work here, this is not an annotation.

https://discuss.python.org/t/type-annotations-pep-649-and-pep-563/11363 for the annotation discussion.

[layday]

Regardless, from __future__ import annotations is 3.7+ only. Sent with [ProtonMail](https://protonmail.com/) Secure Email. ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐

…

On Saturday, October 23rd, 2021 at 05:28, Henry Schreiner ***@***.***> wrote: @henryiii commented on this pull request. --------------------------------------------------------------- In [src/build/__init__.py](#392 (comment)): > @@ -50,7 +50,7 @@ RunnerType = Callable[[Sequence[str], Optional[str], Optional[Mapping[str, str]]], None] ConfigSettingsType = Mapping[str, Union[str, Sequence[str]]] -PathType = Union[str, os.PathLike[str]] +PathType = Union[str, 'os.PathLike[str]'] I think it's safe to do a string inside this, it'll be a ForwardRef. Also, from __future__ import annotations wouldn't work here, this is not an annotation. https://discuss.python.org/t/type-annotations-pep-649-and-pep-563/11363 for the annotation discussion. — You are receiving this because you are subscribed to this thread. Reply to this email directly, [view it on GitHub](#392 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AHNRFWEYU5SMG7LKYL3UB23UIIMVDANCNFSM5GPP54EA). Triage notifications on the go with GitHub Mobile for [iOS](https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675) or [Android](https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub).

[layday]

I personally do not like the unixy 'run-on' parameter names and would much prefer this was source_dir, etc. We also have source_dir and scripts_dir as instance attributes so the discrepancy would persist. We also (also) have a third variant: metadata_directory as an argument to the build method.

[FFY00]

Thank you for working on this! There are some minor issues which need fixing, but otherwise looks good.

[FFY00]

Put this below, see the other release sections for an example.

[bfgray3]

updated in bf3faf7

[FFY00]

Thanks!