Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

env: refactor IsolatedEnv #361

Closed
wants to merge 42 commits into from
Closed

env: refactor IsolatedEnv #361

wants to merge 42 commits into from

Commits on Jan 7, 2022

  1. build: add BuildSystemTableValidationError to module exports

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1ed2ab2 View commit details
    Browse the repository at this point in the history

  2. multi: use same __all__ style and placement in all modules

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    068d0b8 View commit details
    Browse the repository at this point in the history

  3. main: remove redundant re-export 

    "build" is the name of the package.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    36404b4 View commit details
    Browse the repository at this point in the history

  4. multi: refactor isolated env 

    * `IsolatedEnv` reworked to subsume env creation logic.

* `IsolatedEnvBuilder` renamed to `IsolatedEnvManager`.

* `ProjectBuilder.from_isolated_env` added to auto-fill init args from
  an isolated env.

* Made `IsolatedEnv` responsible for customising the environ as a
  prelude to fixing pypa#377.  Removed `ProjectBuilder.scripts_dir`.

* `ProjectBuilder`'s @properties made read-only. Mutating the builder
  is not necessary with the addition of
  `ProjectBuilder.from_isolated_env`.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    2deb0b4 View commit details
    Browse the repository at this point in the history

  5. env: cache min pip version

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1708515 View commit details
    Browse the repository at this point in the history

  6. multi: use module names for loggers 

    DRY.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    74c88e7 View commit details
    Browse the repository at this point in the history

  7. build: reword docstrings for clarity and style

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    e05bce2 View commit details
    Browse the repository at this point in the history

  8. build: factor out parsing pyproject.toml and source dir 

    Fixed passing the absolutised srcdir.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    a44cec7 View commit details
    Browse the repository at this point in the history

  9. tests: adapt tests for new env interface

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c0c6e61 View commit details
    Browse the repository at this point in the history

  10. build: convert runner callback to protocol for better typing

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f7d974b View commit details
    Browse the repository at this point in the history

  11. multi: move type aliases and check_dependency to new module to avoi… 

    …d circular imports
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    e21a372 View commit details
    Browse the repository at this point in the history

  12. multi: add distribution types

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    96e3abe View commit details
    Browse the repository at this point in the history

  13. ci: fix typo

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4f64bbb View commit details
    Browse the repository at this point in the history

  14. docs: don't evaluate parameter defaults 

    For example `sys.executable` would have been expanded on RTD.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    de01a9d View commit details
    Browse the repository at this point in the history

  15. docs: document RunnerCallback's __call__ method

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f86843c View commit details
    Browse the repository at this point in the history

  16. docs: remove API doc blurb 

    There's three modules now which are listed on the sidebar.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    7032c44 View commit details
    Browse the repository at this point in the history

  17. build: remove superfluous type aliases

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    ad3bcc5 View commit details
    Browse the repository at this point in the history

  18. build: make srcdir read-only

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    011ea0b View commit details
    Browse the repository at this point in the history

  19. multi: allow using alternative runners in isolated env

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    9ee527b View commit details
    Browse the repository at this point in the history

  20. util: mute subprocess output in isolated env

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c5b1f0e View commit details
    Browse the repository at this point in the history

  21. main: consistently print errors to stderr

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1035b5d View commit details
    Browse the repository at this point in the history

  22. tests: add from_isolated_env constructor test

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    1e450ab View commit details
    Browse the repository at this point in the history

  23. tests: placate flake8

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    8f0c75a View commit details
    Browse the repository at this point in the history

  24. util: specify type: ignore class 

    Also link to the correct PR.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b628b0a View commit details
    Browse the repository at this point in the history

  25. docs: show items in the order they are defined

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    185fabb View commit details
    Browse the repository at this point in the history

  26. env: use cache from stdlib in 3.9 and above

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    e91856c View commit details
    Browse the repository at this point in the history

  27. coverage: add TYPE_CHECKING to excludes

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d5a755c View commit details
    Browse the repository at this point in the history

  28. env: make prepare_environ return type None-able

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    5819af2 View commit details
    Browse the repository at this point in the history

  29. util: correct typos in docstring

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    fc1b0e4 View commit details
    Browse the repository at this point in the history

  30. tests: combine implicitly concatenated strings on the same line

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    c6d08d4 View commit details
    Browse the repository at this point in the history

  31. env: allow passing custom envs to IsolatedEnvManager 

    The final piece of the env substitution puzzle.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    4387267 View commit details
    Browse the repository at this point in the history

  32. tests: remove isolated env abstractness checks 

    ABCs can't be instatiated with any of their methods being abstract.
These type error because their _other_ methods are abstract, not
because the method being tested is abstract (which it isn't).
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    cdc72e0 View commit details
    Browse the repository at this point in the history

  33. tests: make linenos relative to function emitting warning 

    So we might have to update them less often.

Co-authored-by: Filipe Laíns <lains@riseup.net>
    @layday @FFY00
    layday and FFY00 committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    318270e View commit details
    Browse the repository at this point in the history

  34. env: replace deprecated abc.abstractproperty

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    292ee5f View commit details
    Browse the repository at this point in the history

  35. multi: separate compatibility helpers 

    Adds runtime dependency on typing-extensions.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    55a3c15 View commit details
    Browse the repository at this point in the history

  36. compat: add importlib-metadata

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b6a7994 View commit details
    Browse the repository at this point in the history

  37. main: lint

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    134d271 View commit details
    Browse the repository at this point in the history

  38. env: convert IsolatedEnv to protocol

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    d51a1ea View commit details
    Browse the repository at this point in the history

  39. multi: merge manager into isolated env, split up runner param

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    251fce7 View commit details
    Browse the repository at this point in the history

  40. changelog: add isolated env redesign entry

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    b8fabdc View commit details
    Browse the repository at this point in the history

  41. docs: bump Python to 3.10 

    This is required to display annotations in sphinx which are not generic
at runtime (`os.PathLike`, in particular) in earlier versions of
Python.
    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    f83312a View commit details
    Browse the repository at this point in the history

  42. compat: make typing-extensions an optional dependency once more

    @layday
    layday committed Jan 7, 2022
    Configuration menu
    Copy the full SHA
    631a8d4 View commit details
    Browse the repository at this point in the history