Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manylinux2010 Mark 2 #104

Closed
wants to merge 12 commits into from
Closed

Manylinux2010 Mark 2 #104

wants to merge 12 commits into from

Conversation

safijari
Copy link

This PR is entirely the same as #92 and contains all the original commits from the original authors. All I've done is update the policy number as per the request of @ehashman. I'm not looking to step on any toes, and I certainly do not want to take credit for someone else's work, I just wanna help move this effort forward and do not know of a better way. Apologies for any (many?) mistakes.

markrwilliams and others added 8 commits January 29, 2018 16:55
This script is derived from the explanation in ec6171f's commit
message.  Thanks to @ehashman for describing the source of these
symbols!
- Remove libpanel and libncurses from the lib_whitelist (#94)
- Generate symbol_versions
- Bump priority to 200.
test_manylinux uses an interim manylinux2 image stored on Docker Hub,
and a fork of pip that understands the manylinux2 ABI tag.
@safijari safijari mentioned this pull request Oct 17, 2018
@safijari
Copy link
Author

Travis says the checks pass but I see three errors, all related to pypa/wheel#262. The only fix for this I've seen so far is people freezing wheel to 0.31.1 or some such version.

@ehashman
Copy link
Member

The tests definitely failed, I'm not sure why the script is reporting an exit status of 0. Can you report a bug and I'll try to fix Travis later?

@safijari
Copy link
Author

Okay, I can open an issue (I have some experience with travis so I can try to fix it too).

For now I'm enforcing that wheel version not go above 0.31.1 (pretty much anyone using auditwheel right now is doing this locally in their containers any way).

@safijari
Copy link
Author

Nvmnd, requirements.txt gets superseded by this https://github.com/pypa/auditwheel/blob/master/.travis.yml#L21 😢

@ehashman
Copy link
Member

@safijari I think the tests will fail even if you get this building with the right version of wheel per #106... I would hold off on this PR until I get the regression I mentioned in #107 figured out. Working on tracking it down right now. Thanks for your help!!

@safijari
Copy link
Author

Sounds good, lemme know if I can help with anything else.

@ehashman
Copy link
Member

Hmm, looks like there are some merge conflicts now. Don't worry about this PR @safijari, I'll handle this by fixing up #92.

@ehashman ehashman closed this Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants