Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required --root to ./run_docker` build from source documentation #4754

Merged
merged 1 commit into from
May 10, 2024

Conversation

goulashsoup
Copy link
Contributor

@goulashsoup goulashsoup commented May 10, 2024

Description

It seems --root option is required when running make in the docker container, see #4753

Checklists

  • Add new / update outdated documentation

@hoodmane
Copy link
Member

Well it's not required in general, there is something specific to the way permissions are working on your machine that is breaking it without it. I wouldn't really recommend this either because it has the annoying consequence that all the build artifacts are owned by root and you have to use sudo to remove them.

@hoodmane
Copy link
Member

But thanks for the PR @goulashsoup. How about instead adding the comment that if you see permissions problems when building, passing --root to run_docker can help?

@goulashsoup
Copy link
Contributor Author

But thanks for the PR @goulashsoup. How about instead adding the comment that if you see permissions problems when building, passing --root to run_docker can help?

Can do that as well...

@goulashsoup
Copy link
Contributor Author

@hoodmane Changed it.

@hoodmane
Copy link
Member

Thanks!

@hoodmane hoodmane merged commit 7e1b136 into pyodide:main May 10, 2024
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants