Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds meta.yml for hbdscan. tested on emscripten 3.1.52. #4634

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

type9
Copy link

@type9 type9 commented Mar 23, 2024

Description

Checklists

  • Add a CHANGELOG entry
  • Add / update tests
  • Add new / update outdated documentation

Copy link
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you please add some tests for hdbscan? You can add test_hdbscan.py in the same directory. Please check other test files for example.

- setuptools
- scikit-learn
- joblib
- numpy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only need numpy in requirements/host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants