Add package httpx #4543
Open
Add package httpx #4543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Like aiohttp, it requires a patch to function. Ideally we should add support upstream. Currently only async requests are supported but we can support sync ones too with jspi.
ryanking13
reviewed
Feb 24, 2024
There was a problem hiding this comment.
Thanks! It is very nice to see networking libraries work in Pyodide.
As you wrote, it would be ideal to have these patches upstream in the long term, but what are your plans for the short term?
The current PR doesn't include httpx_patch.py in httpx, so users can't use it, is there a reason you didn't package the actual package?
| license: MIT | ||
| extra: | ||
| recipe-maintainers: | ||
| - PUT_YOUR_GITHUB_USERNAME_HERE |
There was a problem hiding this comment.
Could you put your username here and in other recipes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like aiohttp, it requires a patch to function. Ideally we should add support upstream. Currently only async requests are supported but we can support sync ones too with jspi.
Split off from #3704. On top of #4546.
Checklists